openzipkin/zipkin-js

Add error handlers

Open

#7 opened on Jun 3, 2016

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (167 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

It should be possible for applications to handle errors in the loggers, by adding e.g.

kafkaLogger.on('error', err => console.error('oops', err));

to the code. That means we need to forward the error events from the underlying implementations.

Another alternative is to let users provide their own scribe client or kafka client etc., and let them add error handling directly on their underlying client.

Contributor guide