oracle/oci-cloud-controller-manager

Need to check whether the variable is nil

Open

#340 opened on Jan 7, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (104 forks)auto 404
good first issue

Repository metrics

Stars
 (157 stars)
PR merge metrics
 (PR metrics pending)

Description

According to line 89, resq may be nil, and resp.Body in line 96 will cause a crash. By reading the previous code, resq cannot be nil, so we can remove the comparison in line 89. https://github.com/oracle/oci-cloud-controller-manager/blob/220ab897fd3e8b1bd4b6b6d13a072f477453c073/pkg/oci/instance/metadata/instance_metadata.go#L89-L96

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.