otland/forgottenserver

[Suggestion] Features to place_monster talkaction

Open

#2,940 opened on Apr 12, 2020

View on GitHub
 (8 comments) (1 reaction) (0 assignees)C++ (1,145 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

It has been a while since our !m talkaction has been kinda limited, so here I am to propose some quality of life changes to it:

  • allow monster placement to be in the closest free SQM close to the player, instead of allowing us to create only 8 monsters without moving to another position
  • accept 'amount' parameter, to spawn X monsters instead of one by one
  • proper return error messages, right now it only returns 'There is not enough room.', it would be nice to have it to check if monster name exists and tell if it doesn't

optional changes:

  • accept coordinate as third parameter: "/m 'name'[, 'amount', posX, posY, posZ]"

Contributor guide

Research direction
Start by understanding the existing Lua talkaction script (place monster.lua). Then implement: (1) nearest free tile search using the server's pathfinding or simple flood fill logic; (2) parsing an 'amount' parameter and looping spawn; (3) adding error checks: validate monster name against known monsters, return specific messages. Optionally, add coordinate parameter parsing. Test with local server.
Tech stack
lua
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
LuaC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65