otland/forgottenserver

Yelling should not be sent from floor 7+ to lower floors

Open

#3,322 opened on Feb 16, 2021

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C++ (1,145 forks)auto 404
good first issue

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

depois2

Expected behaviour

the player from the floor bellow ground should not hear anything from above

Actual behaviour

he hears it, same with npc yell

Considerations

I know we are not trying to mimic cibia or anything, but this is just weird after all these years... after all its just a simple check just like https://github.com/otland/forgottenserver/commit/b52a2f799528da37b77ae0bca2148291324b5c85

Contributor guide

Research direction
Study the referenced commit (b52a2f79) to understand the pattern for floor checks, then apply a similar check to prevent yelling from floor 7+ to lower floors. Also verify the NPC yell behavior.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70