otland/forgottenserver

xtea warning when compiling at 32 bits

Open

#3,811 opened on Nov 28, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (1,145 forks)auto 404
good first issue

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. Open solution
  2. Chose Release/Win32
  3. Compile

Expected behaviour

clean compile

Actual behaviour

src\xtea.cpp(44,24): warning C4018: '<': signed/unsigned mismatch

Environment

Windows 10, MSVC 2022

Reproduction environment

That only happens on 32 bits, 64x is fine

Contributor guide

Research direction
Fix the signed/unsigned mismatch in xtea.cpp line 44 by changing the loop variable or index type to unsigned, or adding a static cast.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ compilation basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90