otland/forgottenserver

Top-level constexprs in header files should be inline

Open

#4,063 opened on Apr 2, 2022

View on GitHub
 (0 comments) (3 reactions) (0 assignees)C++ (1,145 forks)auto 404
good first issue

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

When we declare a static constexpr, it means that the value will be present in each compilation unit i.e. each object generated with a cpp file. That means, if a static constexpr is declared in a header file, that every cpp file that includes that header (even indirectly) will have it's own copy of that value.

It can be seen that, if static is removed, the compiler will detect the name clash (which is avoided by static).

These top-level constexprs present in header files should be inline, such that the declarations are merged when the executable is linked and only 1 copy will be present.

Tip: search using regex for ^static constexpr in src/*.h

Contributor guide

Research direction
Search for '^static constexpr' in header files under src/ and replace with 'inline constexpr'.
Tech stack
cpp
Domain
backendgame dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Regex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80