otland/forgottenserver

[Suggestion] Add housePriceAsRent config

Open

#4,081 opened on Apr 17, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (1,145 forks)auto 404
featuregood first issue

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

Explanation of what you want to do that is currently impossible

Most, if not all the maps we download, doesn't have house rent set. Old 0.4 tfs had a handy config.lua setting called housePriceAsRent to be used in this case, because its not funny to calculate and add rent price to each house manually in RME...

Desired functionality

Being able to set house rent price as house price by using a Boolean config.

Available workarounds

none

Prior art

https://github.com/Fir3element/3777/search?q=HOUSE_PRICEASRENT

Contributor guide

Research direction
Locate the existing config system (likely in configmanager.cpp/h), add a new boolean config 'housePriceAsRent', and modify the house rent assignment logic in houses source files to use house price when the config is true.
Tech stack
None
Domain
backendgame dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80