palantir/blueprint

[DateTime] Decouple "Enter to close" from "closeOnSelection" for DateInput/DateRangeInput

Open

#1,988 opened on Jan 11, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: datetimeType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Feature request:

Allow more flexible control over when the popup closes for both DateInput and DateRangeInput

Currently, enter to close only works if "closeOnSelection" is true.

See also: #1825

Contributor guide

Research direction
Understand the current behavior where pressing Enter closes the popup only when closeOnSelection is true. Study the DateInput and DateRangeInput components in the Blueprint source code to identify where the Enter key handler is implemented and how closeOnSelection affects it. Propose a separate prop or modify the logic to allow Enter to close independently.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptBlueprint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40