palantir/blueprint

ButtonGroup inside Label hover state styling bug

Open

#5,289 opened on May 9, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P3Package: coreType: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): core v4.3.0
  • Operating System: macOS
  • Browser name and version: Chrome

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-ge4jfc?file=/src/CoreExample.tsx

Steps to reproduce

  1. Hover over label text

Actual behavior

2022-05-09 09 53 34

First button in group styling changes to hover state. This is confusing because the first button continues to appear hovered even when a user hovers over one of the other buttons -- this makes it ambiguous what may be selected or clicked on "mousedown".

Expected behavior

No button hover styling when hovering over the label text. When hovering over one of the buttons, only that one should get hover styling.

Possible solution

Contributor guide

Research direction
Investigate CSS hover styles on ButtonGroup when nested inside Label. Look for CSS selector conflicts or event propagation issues causing the hover state to incorrectly apply to the first button.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65