palantir/blueprint

Generically typed selection UI

Open

#6,695 opened on Feb 1, 2024

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Status: needs proposalType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Feature request

Would be nice to have a selection UI that works with enums. SegmentedControl is nice but the callback is always string

Examples

const options: {label: string, value: MyEnum} = {...};

const handleValueChange = (newValue: MyEnum) => {...};

... 

<SegmentedControl<MyEnum> options={options} onValueChange={handleValueChange}>
...
</SegmentedControl>

Contributor guide

Research direction
Review the existing SegmentedControl component implementation and type definitions in the Blueprint repository. Understand how it currently handles the 'value' callback as a string. Then, propose changes to make the component generic, allowing users to specify a custom value type via a type parameter. Ensure that the change maintains backward compatibility and updates the examples in the documentation.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70