parthenon-hpc-lab/athenapk

Split of cooling time cfl

Open

#11 opened on Nov 17, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (33 forks)auto 404
good first issue

Repository metrics

Stars
 (74 stars)
PR merge metrics
 (PR metrics pending)

Description

The adaptive and Townsend integrators do not require a limitation on the timestep a priori. Nevertheless, from a physical point of view it may be desired to limit the timestep anyway so that the thermal dynamics and other dynamics don't decouple. While this is currently supported/tied to the adaptive rk12, and rk45 cooling integrators, we should separate that option and properly document it.

Contributor guide

Research direction
Examine the existing cooling integrators (rk12, rk45) to find where the timestep limitation is implemented. Design a generic timestep limiter that can be applied independently of the chosen integrator. Implement and document the separation, ensuring backward compatibility.
Tech stack
None
Domain
backendhpc
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++KokkosBasics of timestep control in CFD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45