photoprism/photoprism

Display HTTP 4xx Error Code if it occurs (eg if upload in webapp fails)

Open

#3,155 opened on Jan 31, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (2,263 forks)batch import
help wantedux

Repository metrics

Stars
 (39,670 stars)
PR merge metrics
 (Avg merge 4d) (26 merged PRs in 30d)

Description

1. What is not working as documented?

Original issue: uploads via webapp not possible Original symptoms:

Uploading Pictures via web app (three dot menu -> upload cloud icon) 
to self hosted docker compose :latest package
when executing import for 2 photos from iOS (ipad, iphone) any browser (safari, chrome, firefox) 
    --> regular indexing happens but nothing is being imported, no error, no success.

Root Cause in my case: Nginx default configuration allows 1m post upload. After client_max_body_size 64M; is configured, all works fine.

This leads to: What is not working as documented?

Photoprism isn't reacting to HTTP 413 error.

2. How can we reproduce it?

  1. Go to example.com/photoprism
  2. Click on 'three dots' -> 'cloud with upload arrow' -> 'upload cloud with arrow'
  3. Chose a picture larger than configured client_max_body_size -> click on 'add'
  4. Wait and see that the processing happens without showing an error
  5. Check Search / Review and not find the uploaded pictures

3. What behavior do you expect?

upload fails with information that file is too large

Contributor guide

Research direction
Inspect the upload API endpoint in the Go backend to see the error response for 413, then check the frontend code (likely in a JavaScript framework) for how upload errors are handled, and add a user visible error message when an HTTP 4xx error occurs.
Tech stack
go
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBasic understanding of web development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
72