piskvorky/gensim

proper check for filename before calling subprocess

Open

#1,485 opened on Jul 14, 2017

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Python (4,349 forks)batch import
Hacktoberfestbugdifficulty mediumgood first issue

Repository metrics

Stars
 (15,144 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Based on discussion here, we should properly check for filename before process calls in utils.check_output(), and raise more intuitive exception and error message.

cc @jayantj

Contributor guide

Research direction
Inspect the check output function in gensim/utils.py and add a filename validation before the subprocess call.
Tech stack
python
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80