piskvorky/gensim

TextCorpus.sample_texts() does not use get_texts()

Open

#1,990 opened on Mar 20, 2018

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Python (4,349 forks)batch import
Hacktoberfestbugdifficulty easy

Repository metrics

Stars
 (15,144 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The sample_texts() method is supposed to return sample documents but if an implementation derives from TextCorpus and overrides get_texts(), this is completely ignored by the implementation of sample_texts() which uses getstream() only. This applies to the most recent develop (58d560b545e6df4cfc5fd3879f8647ba3a7a0e3b) and maste (885430d136c87c613ab58ad6b1dc55fee47a43c7) branches.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.