piskvorky/gensim

KeyedVectors TODOs

Open

#2,166 opened on Aug 26, 2018

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Python (4,349 forks)batch import
Hacktoberfestdifficulty easydocumentation

Repository metrics

Stars
 (15,144 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Hi! I'm new here :) I was digging through the Doc2Vec code and came across a bunch of TODOs in KeyedVectors.

I was wondering if TODOs such as https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/keyedvectors.py#L1601 in KeyedVectors can be implemented using model.infer() like in https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/keyedvectors.py#L1801

If so I'll be happy to submit a PR.

Steps/Code/Corpus to Reproduce

N/A

Expected Results

N/A

Actual Results

N/A

Versions

Darwin-15.6.0-x86_64-i386-64bit Python 3.6.4 (default, Jan 6 2018, 11:49:38) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] NumPy 1.15.1 SciPy 1.1.0 gensim 3.5.0 FAST_VERSION 0

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.