pnp/cli-microsoft365

Bug: superseding rules works incorrectly

Open

#2,593 opened on Jul 16, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (399 forks)auto 404
bughelp wantedkeep-open

Repository metrics

Stars
 (1,390 stars)
PR merge metrics
 (PR metrics pending)

Description

Discussed in https://github.com/pnp/cli-microsoft365/discussions/2590

When upgrading SPFx project from 1.11 to 1.12, CLI won't suggest removing rush-stack-compiler 3.3. While the rule is there, it's superseded by installing rush-stack-compiler 3.7. The problem is, that currently superseding doesn't take into account the difference between installing and uninstalling the package. We need to think about how to handle it as currently superseding is handled centrally outside the rule.

One way could be to replace the array of superseded rule IDs with a method that takes a rule as an argument. That way, the rule could examine other rule's properties and return a bool true or false depending if the rule should be superseded or not.

Contributor guide