pnp/cli-microsoft365

[Bug] Without the required scope errors returned from 'tenant people profilecardproperty' commands are vague

Open

#5,629 opened on Nov 3, 2023

View on GitHub
 (14 comments) (0 reactions) (0 assignees)TypeScript (399 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (1,390 stars)
PR merge metrics
 (PR metrics pending)

Description

I don't have the required scope added yet to my app reg but the error returned is a bit vague:

image

That's probably because the error object coming in from the Graph has an empty message. :( image not sure how to solve this here... The MS Graph team should make this more descriptive, or we should implement checks based on the HTTP status code.. But that seems a change that would impact a lot of other code.

Originally posted by @martinlingstuyl in https://github.com/pnp/cli-microsoft365/issues/5624#issuecomment-1791486402

Contributor guide

Research direction
Investigate how the CLI handles Graph API error responses. Look for patterns where error message is empty and propose fallback messages based on HTTP status codes or scope requirements. Check existing error handling in similar commands.
Tech stack
typescript
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60