portapack-mayhem/mayhem-firmware

GURU fault when file path+name >64 characters in Notepad (LOW PRIORITY)

Open

#1,339 opened on Aug 1, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (877 forks)auto 404
buggood first issue

Repository metrics

Stars
 (5,160 stars)
PR merge metrics
 (Avg merge 6d 15h) (29 merged PRs in 30d)

Description

To reproduce, open Notepad app, press Select to open File Manager, and click on a file with a 64+ character path to open in Notepad, and a GURU meditation fault occurs in set_focus_widget(). Examples of long file names that will cause this fault:

DEBUG/DEBUG_DUMP_0000_20230801_20230801_20230801rrrrxxyy001.TXT

LOGS/ADSB_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728_20230728.TXT

guru-fault

I realize that File Manager has a define for 64 character maximum file name, but I'd like to understand the reason for the fault. (Also, increasing the max file name length in File Manager does not prevent the fault.)

Affected firmware versions include v1.7.4

Contributor guide

Research direction
Investigate the set focus widget() function in the Notepad app source code. Look for fixed size buffers that may overflow when the file path exceeds 64 characters, and trace the call path from file selection to the fault.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75