public-transport/gtfs-via-postgres

Missing SRID 4326 for shapes_aggregated.shape

Open

#48 opened on Sep 26, 2023

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (21 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (141 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I suggest to explicitly set SRID 4326 for shape geometries in shapes_aggregated, e.g.

ST_SetSRID(4326, ST_MakeLine(array_agg(shape_pt_loc))) AS shape

That way, subsequent (materialized) views coud create a spatial index like e.g.

CREATE INDEX my_shapes_aggregated_view_shape_idx
ON my_shapes_aggregated_view_shape
USING GIST (shape);

Contributor guide

Research direction
Edit lib/shapes.js line 40 to wrap ST MakeLine with ST SetSRID(4326, ...). Then rebuild the database and verify the shape column has SRID 4326.
Tech stack
javascriptpostgresql
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPostgreSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90