public-transport/hafas-client

nearby: throw if nr of stations is above supported maximum

Open

#13 opened on Jan 19, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (60 forks)github user discovery
add testsbreakingenhancementhelp wanted

Repository metrics

Stars
 (353 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Apparently the VBB API will only return a certain number of stations. Throw if the passed value is above.

Contributor guide

Research direction
Identify the maximum number of stations supported by the VBB API, locate the `nearby` function in the codebase, and add a check that throws an error if the `stations` parameter exceeds that maximum.
Tech stack
javascript
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75