public-transport/hafas-client

departures: throw if duration is above supported maximum

Open

#14 opened on Jan 19, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (60 forks)github user discovery
add testsbreakingenhancementhelp wanted

Repository metrics

Stars
 (353 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

From https://github.com/derhuerst/compute-db-station-weight/blob/dda148fa533d7497b5d24737d2d1246407719aa9/index.js#L42-L43

Apparently, the DB API does not support querying departures for 1440 min (1 day) at once.

Throw if the passed value is above to prevent implementations from implicitly relying on this gotcha.

@juliuste do you know the limit for ÖBB?

Contributor guide

Research direction
Find where duration is passed to the API and add a check that throws if it exceeds the maximum supported value (e.g., 1440 minutes for DB). Look for existing validation patterns in the codebase.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75