public-transport/hafas-client

Collect (And Remove) Prefixes in Train Names

Open

#172 opened on Mar 26, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (60 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (353 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello. For some time, the MMM-PublicTransportHafas on my magic mirror displays ugly train names. Instead of "S3", it now says "ABR S3" which tells me the train is being operated by a private company named abellio.

This issue is about collecting trains and connections that have this issue to parse them (I guess)

Contributor guide

Research direction
Examine the code that parses train names from HAFAS responses, identify where the prefix like 'ABR' is prepended, and implement logic to strip known operator prefixes from the display name.
Tech stack
javascript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60