public-transport/hafas-client

journeys(): Walks have wrong distance

Open

#298 opened on Sep 14, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (60 forks)github user discovery
docshelp wantedprofile:dbprofile:mobil-nrwprofile:sbahn-muenchenprofile:vrnquestionupstream

Repository metrics

Stars
 (353 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've noticed that legs that are walks have an incorrect distance value. The value is generally about 500 meters greater than the one displayed in DB Navigator, but the offset unfortunately doesn't really seem follow a pattern. Here are some examples:

from to DB Navigator hafas-client difference
Berlin Hbf (tief) Berlin Hbf (S-Bahn) 80 500 420
Hamburg Hbf Hauptbahnhof Süd, Hamburg 243 666 423
Köln Messe/Deutz Köln Messe/Deutz Gl.11-12 59 615 556
München Hbf (tief) München Hbf 130 692 562

This problem seems to be there on a lot of/maybe all profiles (I haven't tried all). I noticed it with the db profile. Options like a different walking speed or transfer time don't affect this.

Contributor guide

Research direction
Inspect the walking distance calculation in the journeys() function. Compare raw HAFAS response for walking legs with the parsed output to identify where the extra distance is introduced.
Tech stack
javascript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70