pydantic/FastUI

Support srcdoc attribute in iframe component.

Open

#150 opened on Jan 14, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (341 forks)github user discovery
help wanted

Repository metrics

Stars
 (8,970 stars)
PR merge metrics
 (PR metrics pending)

Description

Do you think it would be reasonable to add srcdoc attribute support to the iframe component? This would enable embedding arbitrary html. The sandbox attribute might go along with this in order to enable scripts.

For context, I have been looking into doing some data visualisation in FastUI but this could also be useful for embedding reports, for example from MultiQC.

# Use it in FastUI like:
c.Iframe(srcdoc='<p>FastUI is neat</p>', src='https://pydantic.dev', width='100%', height=400),

Contributor guide

Research direction
Examine the Iframe component's implementation in FastUI's codebase, likely under fastui/components.py or similar, and add the srcdoc attribute to the component's props, ensuring it works with sandbox attribute if needed. Then update the documentation and tests.
Tech stack
pythonreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPythonReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70