pylint-dev/pylint

Question: Is there a reason that `invalid-envvar-default` only checks `os.getenv`, not `os.environ.get`

Open

#10,092 opened on Nov 22, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Python (1,059 forks)batch import
False Negative 🦋Good first issueHacktoberfestHelp wanted 🙏Needs PR

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 12h 9m) (29 merged PRs in 30d)

Description

is there a reason that invalid-envvar-default only checks os.getenv, not os.environ.get?

https://github.com/pylint-dev/pylint/blob/68cb5b320653ad64c68ff48a4bb4ba449a01d3a6/pylint/checkers/stdlib.py#L33

Contributor guide

Research direction
Investigate the pylint checker code to understand why only `os.getenv` is checked and consider adding support for `os.environ.get`. Modify the AST visitor to also check calls to `os.environ.get` with a default argument.
Tech stack
python
Domain
developer experience
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70