pypa/gh-action-pypi-publish

Adaptive short-lived token expiration handling

Open

#307 opened on Nov 30, 2024

View on GitHub
 (13 comments) (0 reactions) (2 assignees)Python (118 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (1,175 stars)
PR merge metrics
 (PR metrics pending)

Description

So it happened that a short-lived token in yarl started expiring before all uploads managed to complete.

This resulted in having to yank two releases: https://pypi.org/project/yarl/1.18.2/#history

The last failure started uploading things but didn't complete in 15 minutes, eventually hitting the token expiration: https://github.com/aio-libs/yarl/actions/runs/12091091291/job/33719944175#step:9:729

The last successful upload had the step with this action running for 4 minutes https://github.com/aio-libs/yarl/actions/runs/11954909206/job/33329106474#step:9:768

@woodruffw I don't know what exactly caused the slowness, but I think that maybe we should re-request that token every couple of dists if the cumulative size of the uploads is big. I suppose that adding the attestations doubles the number of uploads, which might also affect the overall upload time.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.