pypsa-meets-earth/pypsa-earth

Simplify network lead to a bug in GADM shapes

Open

#382 opened on Jun 16, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (349 forks)auto 404
buggood first issuehelp wanted

Repository metrics

Stars
 (351 stars)
PR merge metrics
 (PR metrics pending)

Description

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-africa environment. Update via conda env update -f envs/environment.yaml.

Describe the Bug

Summary of bugs:

  • Administrative zone is removed in gadm_regions to onshore_regions conversion
  • Multiple administrative zones are associated to one shape after simplify_network.

I am running PyPSA-Africa for Nigeria with the GADM clustering option which retrieves GADM shapes also known as administrative zones. See the automatic download: gadm-shapes Creating the regions_onshore looks still fine. I am not sure yet what the colour change means. Maybe it is indicating an error? One bug is that black hole inside Africa! regions_onshore Nevertheless, the real bug appears when running simplify_network.py which then creates networks/elec_s{simpl}.nc. As you can see, hovering over one shape, it seems that some shapes are combined. regions_onshore_elec_s

One needs to debug simplify_network and investigate the step where this occurs. We need to find a solution to this issue.

Contributor guide

Research direction
Investigate the simplify network script to identify why GADM administrative zones are incorrectly merged or removed during the conversion and simplification process. Focus on the steps converting gadm regions to onshore regions and the subsequent simplification in network creation.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
PythonGIS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40