pypsa-meets-earth/pypsa-earth

CI error when gadm server is down: add GADM file to datakits

Open

#889 opened on Oct 8, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (349 forks)auto 404
bugdatagood first issueinputs

Repository metrics

Stars
 (351 stars)
PR merge metrics
 (PR metrics pending)

Description

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-earth environment. Update via conda env update -f envs/environment.yaml.

Describe the Bug

Please provide a description of what the bug is and add a minimal example/command for reproducing the bug.

With the latest updates, the CI bundles should contain the appropriate gadm data and as such the workflow should not attempt to download them again and trigger the error. This clearly doesn't work and shall be checked.

In particular, there is the need to verify this line: https://github.com/pypsa-meets-earth/pypsa-earth/blob/b205e83c3b631448a778e29257eed551790b9d5c/scripts/build_shapes.py#L100 In the CI case, that condition should be false and so no access to the Davis server should be requested.

@yerbol-akhmetov this is related to what you are experiencing

It should be a quick fix also for new users in case

Contributor guide

Research direction
Identify why the condition in build shapes.py line 100 is true in CI and ensure it is false when GADM data is already bundled.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75