qmk/qmk_firmware

One shot mod keys locking when tapped in succession

Open

#10,872 opened on Nov 6, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (Avg merge 20d 9h) (27 merged PRs in 30d)

Description

Problem

My one shot mod keys are locking when tapped in succession with no alphanumeric characters in between. This often happens as a typo (I hit the wrong mod key for what I want to do), or if I decide to do something different midway. It took me almost a year determine the sequence that triggers this behavior.

How to Reproduce

If I do Ctrl-Alt-Alt, Ctrl is locked until I long hold it.

Same for sequences like Alt-OS-OS where Alt is locked

Keyboard

Corne keyboard

OSM Bindings

#define OSM_CTL OSM(MOD_LCTL)
#define OSM_ALT OSM(MOD_LALT)
#define OSM_OS  OSM(MOD_LGUI)

Contributor guide

Research direction
Investigate the one shot mod (OSM) implementation in QMK to understand why tapping OSM keys in succession without alphanumeric keys causes the first mod to lock. Trace the code path for OSM key press and release events.
Tech stack
c
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50