randombit/botan

Consolidate/fix BSD socket layer code

Open

#2,216 opened on Dec 6, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (654 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (3,283 stars)
PR merge metrics
 (PR metrics pending)

Description

socket.cpp, socket_udp.cpp and cli/socket_utils.h have a lot of shared/duplicated code for handling differences in socket interface between BSD and Windsock. Consolidate into a single internal header which can be used across all three.

Contributor guide

Research direction
Examine the socket files (socket.cpp, socket udp.cpp, cli/socket utils.h) to identify duplicated code patterns between BSD and Winsock. Propose a single internal header that uses preprocessor conditionals to consolidate platform specific socket interface differences.
Tech stack
cpp
Domain
networkingbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Socket Programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55