rapidsai/cuml

[FEA] cpp-bench: refactor the `read_csv` method into a more common place

Open

#1,155 opened on Sep 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (644 forks)auto 404
? - Needs TriageCUDA / C++Tech Debtfeature requestgood first issuequick-hit

Repository metrics

Stars
 (5,223 stars)
PR merge metrics
 (PR metrics pending)

Description

Filing this issue as per the comment by @cjnolet here. It certainly makes sense to move this logic somewhere which can help increase reuse. However, I'd also like to caution that this function was tailor-made for numerical values only and also only tested for dense csv files! So, we might want to spend some effort on making this function slightly more generic, before migrating it for a wider use inside cuML.

Contributor guide

Research direction
Inspect the current `read csv` method in the cpp bench codebase, understand its dependencies and usage, and identify a suitable common location (e.g., utility library) within cuML where it can be refactored for reuse across C++ components.
Tech stack
cpppython
Domain
backendmachine learning
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40