rapidsai/cuml

[DEBT] add checks for the spectral unit-tests!

Open

#1,676 opened on Feb 13, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (644 forks)auto 404
CUDA / C++Tech Debtgood first issuetests

Repository metrics

Stars
 (5,223 stars)
PR merge metrics
 (PR metrics pending)

Description

Current unit-tests for spectral clustering/embedding only run the code, but doesn't do any checks on the resulting clusters/embeddings! This is a testing hole and must to be fixed for a better coverage. The source file of interest is cpp/test/sg/spectral_test.cu.

Contributor guide

Research direction
Add assertions to the existing spectral test functions in cpp/test/sg/spectral test.cu to verify that the clustering or embedding results are correct. Look at similar test files in the repository for patterns.
Tech stack
cpppython
Domain
machine learning
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60