rapidsai/cuml

Create preprocessor macros to standardize annotations

Open

#6,532 opened on Apr 10, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (644 forks)auto 404
CUDA/C++good first issue

Repository metrics

Stars
 (5,223 stars)
PR merge metrics
 (PR metrics pending)

Description

This came up in https://github.com/rapidsai/cuml/pull/6525 which attempted to remove ODR violations, and we noticed that check-symbols in CI fails even after removing the ODR violations. This is due to the fact that these kernels are called across TU boundaries and the issue is separate from satisfying ODR.

The fix for check-symbols was to mark the kernels as static. Per @vyasr https://github.com/rapidsai/cuml/pull/6525#issue-2984054211, we should define preprocessor macros that standardize how we annotate our kernel and device functions in cuML.

Contributor guide

Research direction
Review the discussion in PR #6525 to understand the ODR violation issue and the need for static. Then define preprocessor macros for kernel/device function annotations (e.g., `CUM KERNEL`, `CUM DEVICE`) that standardize visibility and linkage across translation units. Look at existing codebase for patterns and ensure macros are applied to all relevant functions.
Tech stack
ccpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60