rizinorg/cutter

Useless asm.lines option in settings

Open

#1,964 opened on Dec 21, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (1,123 forks)batch import
QuestionUIgood first issue

Repository metrics

Stars
 (14,852 stars)
PR merge metrics
 (Avg merge 13d 23h) (20 merged PRs in 30d)

Description

Environment information

  • Operating System: Any
  • Cutter version: 1.10
  • File format: Any

Describe the bug

Settings currently contains "Show jump lines (asm.lines)" option. Since Cutter has it's own mechanism for drawing them this option currently does nothing.

Expected behavior

One of the two:

  • Show jump lines affects jump lines drawn by Cutter
  • Show jump lines option is removed from Cutter settings

Contributor guide

Research direction
Examine the settings UI code and the asm.lines option. Determine if the option should be removed or wired to Cutter's jump line drawing.
Tech stack
cpp
Domain
reverse engineering
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75