Use more accessible ui elements for family_requests form
#136 opened on Jul 26, 2019
Repository metrics
- Stars
- (29 stars)
- PR merge metrics
- (PR metrics pending)
Description
On the family_requests/new form we use a fancy toggle instead of a vanilla checkbox for the include? column of the table. It would be awesome to use the same toggles for the checkboxes for active and archive on the children form as we do there. Currently we have plain html checkboxes.
These fancy on off mobile style toggles on the Family requests form cannot be accessed by keyboard. Also for a user who is colorblind, it might be unclear which way is "toggled on" vs "toggled off"
I think reverting these to vanilla checkboxes and changing the title of the column to "Include in request?" would do the trick. Also, currently it looks like when these toggles are clicked they send a request in the background to update the childs active column. I think this could be confusing if someone were to start the creation of a family request and abandon it before submitting, (updating the children to inactive with little feedback to the user) I think these updates are fine to do but we should probably wait until the form is submitted and the request created to finalize it.