rubyforgood/voices-of-consent

/requesters/new not showing the correct errors

Open

#399 opened on Nov 30, 2019

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Ruby (80 forks)auto 404
Priority: Mediumhelp wanted

Repository metrics

Stars
 (40 stars)
PR merge metrics
 (PR metrics pending)

Description

When all required fields are populated and one of them has incorrect data the form shows an email error instead of the correct errors.

This is happening due to https://github.com/rubyforgood/voices-of-consent/blob/71e627f0a324084bf43b32084712ba1b319cf7b4/app/javascript/src/components/box-request-form/BoxRequestForm.js#L245

Replicate steps:

  • Go to http://localhost:5000/requesters/new
  • Populate all fields and make sure email is valid, and phone and zip-code are not valid (for example add letters only)
  • Submit
  • An error shows up saying that the email is wrong, although what is wrong are the fields phone and zip-code

Contributor guide

Research direction
Investigate the validation logic in BoxRequestForm.js around line 245 to understand why a valid email triggers an error when other fields are invalid. Trace the form submission handling and error display flow.
Tech stack
rubyjavascript
Domain
frontendbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRuby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65