rust-vmm/vhost

Regenerate vhost_binding.rs and move custom changes in another file

Open

#188 opened on Sep 15, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (98 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (163 stars)
PR merge metrics
 (PR metrics pending)

Description

In a PR #185, we fixed some new clippy warnings, but there is one related to __IncompleteArrayField that should be auto-generated by bindgen.

We used an old version that generated also Copy/Clone implementations, but now it looks like they removed it: https://github.com/rust-lang/rust-bindgen/issues/1431

@jiangliu agreed on regenerate it with a new version of bindgen. We also modified a bit the vhost_binding.rs generated file, so it may be better to move the new struct in another file, so we can update it easily next time

Contributor guide

Research direction
Investigate the current usage of bindgen in the repository, update to the latest version, regenerate vhost binding.rs, and move any custom structures (like IncompleteArrayField) into a separate file to preserve manual changes.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGitbindgen
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55