sapegin/mrm-core

`copyFiles` remove EOF

Open

#25 opened on Dec 21, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (14 forks)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (33 stars)
PR merge metrics
 (PR metrics pending)

Description

I think problem here https://github.com/sapegin/mrm-core/blob/f21ca5be125aef3f49cef126a41a4e62845c83bb/src/fs.js#L11

Contributor guide

Research direction
Check the copyFiles function in src/fs.js, specifically line 11, to understand why it removes the end of file (EOF) newline and propose a fix.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85