shawnbot/sast

Sass Interpolations are not correctly stringified

Open

#12 opened on Dec 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (PR metrics pending)

Description

Sass interpolations (https://sass-lang.com/documentation/interpolation) are parsed correctly, but stringify() removes them, resulting in incorrect code.

Steps to reproduce:

const tree = sast.parse('width: calc(100% - #{2 * $spacer})', { syntax: 'sass' });
console.log(sast.stringify(tree));

// should output: width: calc(100% - #{2 * $spacer})
// current output: width: calc(100% - 2 * $spacer)

This happens for both sass and scss.

Contributor guide

Research direction
Examine the stringify function in the source code to see how interpolation nodes are handled. Identify the missing serialization logic and add it.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75