shoelace-style/shoelace

sl-dialog tab issue with date and time input types

Open

#2,437 opened on May 1, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (922 forks)github user discovery
bugfixed-in-wahelp wanted

Repository metrics

Stars
 (13,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug

When using <input type="date"> or <input type="time"> modern browsers have multiple sub-fields inside each element that can normally be tabbed to, but when used inside an this tabbing behavior is broken and tab will jump to the next element.

To Reproduce

Steps to reproduce the behavior:

  1. Create an sl-dialog component
  2. Create a date or time input inside the component
  3. Try to use tab to navigate to the various sub-fields inside the input

Demo

https://codepen.io/shadedream/pen/EaaQYZw

Screenshots

N/A

Browser / OS

  • OS: Mac, Windows
  • Browser: Firefox, Chrome, Safari
  • Browser version: FF 137.0.2, Chrome 136.0.7103.49, Safari 18.4

Additional information

In the codepen, you can see the behavior inside and out of the sl-dialog for comparison.

Contributor guide

Research direction
Investigate the focus trapping logic in the sl dialog component. Check how it handles tab key navigation and why it breaks native tab behavior for date/time inputs with sub fields. Look at the code that manages focus within the dialog, especially the part that programmatically moves focus. Consider using `tabindex` or `focusin`/`focusout` events to allow native tabbing within these inputs.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitHTMLCSSWeb Components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65