sillsdev/languageforge-lexbox

Minor improvement to BulkCreateEntries

Open

#2,305 opened on May 28, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (6 forks)auto 404
Good first issue📖 MiniLcm

Repository metrics

Stars
 (7 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the feature BulkCreateEntries currently calls logger.LogInformation("Added {Count} entries so far", entryCount) every 1000 entries, but doesn't log the total number of entries when it finishes. It's probably worth adding one more log entry at the very end of BulkCreateEntries (even after regenerating the entry search table): logger.LogInformation("Added {Count} entries", entryCount). That way the log will contain not just an every-1000-entries progress message, but also a note of precisely how many entries were added by the bulk operation. Which would be useful slightly more often than the current behavior, where a progress message is logged but the total number is not.

Contributor guide