simonw/download-esm

Make this robust in the face of more packages

Open

#2 opened on May 2, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (9 forks)github user discovery
help wanted

Repository metrics

Stars
 (125 stars)
PR merge metrics
 (PR metrics pending)

Description

So far I've tested this on exactly one package: @observablehq/plot.

It would be good to test this on some other packages too! Help very much appreciated here.

Any packages that don't work can be used to expand the test suite. It's all in triple-string-literals in https://github.com/simonw/download-esm/blob/0.1a0/tests/test_download_esm.py at the moment, but it would make sense to turn those HTTPX fixtures into actual files on disk as it expands.

Contributor guide

Research direction
Explore the current test file, find packages that cause failures, add them to the test suite, and refactor fixtures into files.
Tech stack
pythonnodejs
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PythonGitnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70