sindresorhus/electron-unhandled

Add a filter option

Open

#18 opened on Apr 1, 2020

View on GitHub
 (7 comments) (7 reactions) (0 assignees)JavaScript (27 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (464 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be great if we had a configurable filter function that, if defined in the options, gets called BEFORE the options.logger and showMessageBox function get called and returns true or false to decide if the error should pass or not.

That way one could filter out error messages like ERR_CONNECTION_REFUSED that are not catchable

Contributor guide

Research direction
Locate the error handler in the source code where logger and showMessageBox are called. Add a new optional 'filter' function property to the options object. In the handler, call the filter function with the error; if it returns false, skip the default handling.
Tech stack
javascriptnodejs
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75