sindresorhus/linkify-urls

Parentheses in URLs break linkifying

Open

#28 opened on Nov 7, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (23 forks)user submission
bughelp wanted

Repository metrics

Stars
 (173 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

@fregante edit: Issue transferred from refined-github. This issue still happens in v3.1.0

See this line:

The URL contains parentheses which make the anchor cut off the URL in both the href and the visual link producing a wrong URL.

Original valid URL:

https://github.com/jserz/js_piece/blob/master/DOM/ParentNode/append()/append().md

Contributor guide

Research direction
Inspect the linkify function to understand how URLs are detected and modify the regex to include parentheses as valid URL characters.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70