sindresorhus/sort-on

Add the ability to sort boolean values

Open

#18 opened on Mar 21, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (14 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (200 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently, invoking:

sortOn([{x: true}, {x: false}], 'x')

Is returning:

[{x: true}, {x: false}]

It would be nice to return the following instead:

[{x: false}, {x: true}]

Cheers! 😄

Contributor guide

Research direction
Write a test case for boolean values, then update the sort comparator to handle booleans by ordering false before true.
Tech stack
javascript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85