sindresorhus/trash

Trashing a file on Windows deletes it unrecoverably if no recycle bin is enabled

Open

#107 opened on Dec 11, 2020

View on GitHub
 (5 comments) (1 reaction) (0 assignees)JavaScript (81 forks)user submission
bughelp wanted

Repository metrics

Stars
 (2,660 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Similar to #56, but probably has to be solved in a different way for Windows. This was reported by a user in my app losslesscut https://github.com/mifi/lossless-cut/issues/537 When he trashed a file on a network mounted drive (which has no trash), the file just got removed permanently.

Contributor guide

Research direction
Investigate how the Windows trash API behaves when no recycle bin is available. Look into using `fs.stat` or Windows specific methods to detect if a drive has a recycle bin. Consider implementing a fallback that shows a warning or uses a different deletion method.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsFilesystem APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70