sindresorhus/type-fest

Jsonify breaks down with JsonValue, JsonObject

Open

#582 opened on Mar 27, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (471 forks)batch import
bughelp wanted

Repository metrics

Stars
 (12,328 stars)
PR merge metrics
 (Avg merge 3d 5h) (11 merged PRs in 30d)

Description

I was trying to use Jsonify with a generic class and noticed things would break if I happened to pass in a type already using JsonValue or JsonObject:

// type Foo = {[x: string]: never}
type Foo = Jsonify<JsonObject>

// Type instantiation is excessively deep and possibly infinite.ts(2589)
type Bar = Jsonify<JsonValue>;

Contributor guide

Research direction
Examine the Jsonify type definition for missing base cases causing infinite recursion when applied to JsonValue or JsonObject. Add type checks to avoid self referencing.
Tech stack
typescript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70