sindresorhus/type-fest

`PartialDeep` make `Date` internal structure partial

Open

#719 opened on Oct 20, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (471 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (12,328 stars)
PR merge metrics
 (Avg merge 3d 5h) (11 merged PRs in 30d)

Description

I've noticed that when you apply PartialDeep to something containing Date it makes the Date internal structure partial, which causes some errors when combining it with zod validations for instance.

Should it skip internal JS classes like Date while making something partially deep?

I've found https://github.com/sindresorhus/type-fest/pull/342, but I still see the issue on version v4.4.0, might be a regression?

Contributor guide

Research direction
Inspect the PartialDeep type definition and ensure that built in types like Date are excluded from partialization. Check for regressions from PR #342.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70