smart-on-fhir/cumulus-etl

Stop stripping ¿ from notes in general

Open

#301 opened on Mar 14, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (8 forks)auto 404
enhancementgood first issuei2b2

Repository metrics

Stars
 (25 stars)
PR merge metrics
 (PR metrics pending)

Description

We saw some artifacts in our BCH i2b2 data and started stripping ¿ characters broadly. But that's a little hokey.

https://github.com/smart-on-fhir/cumulus-etl/blob/e551495c3514ad86cfb25f3063346ec88f7d8c73/cumulus_etl/fhir/fhir_utils.py#L221

We should limit that kind of note manipulation to the i2b2 code specifically, ideally.

Contributor guide

Research direction
Locate the fhir utils.py file and the function that strips ¿. Identify where i2b2 specific code is and move the stripping logic there, ensuring it doesn't apply to all notes.
Tech stack
python
Domain
backenddata engineering
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75