srid/haskell-flake

`cabal.project` parse error due to leading comment

Open

#193 opened on Aug 21, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Nix (26 forks)github user discovery
good first issue

Repository metrics

Stars
 (231 stars)
PR merge metrics
 (PR metrics pending)

Description

May be slightly different error than https://github.com/srid/haskell-flake/issues/186

I believe the leading comment

-- This project config requires cabal 2.4 or later

-- If in doubt, use GHC 8.8 to build hackage-server; see
-- 'tested-with' in 'hackage-server.cabal' for a list of currently
-- CI-validated GHC versions
--
-- with-compiler: ghc-8.8

packages: .

causes an error, in addition to the error on the packages line.

Fails with error: https://github.com/peterbecich/hackage-server/blob/cabal-project-parsing-error/cabal.project branch: https://github.com/peterbecich/hackage-server/tree/cabal-project-parsing-error

Succeeds: https://github.com/haskell/hackage-server/blob/06f831ef7a701967f22128087b3817cdff185cbc/cabal.project branch: https://github.com/peterbecich/hackage-server/tree/update-flake PR: https://github.com/haskell/hackage-server/pull/1244

Thanks again

Contributor guide

Research direction
Inspect the cabal.project parsing code to handle leading comments before the packages line.
Tech stack
haskell
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HaskellCabal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85